feat: support passing profile init option #321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
1 task
License: MIT Signed-off-by: Alan Shaw <[email protected]>
alanshaw
force-pushed
the
feat/support-profile
branch
from
9f1f024 to
3ec28af
Compare
daviddias
approved these changes
Feb 11, 2019
daviddias
requested changes
Feb 11, 2019
Member
daviddias
left a comment
daviddias
left a comment
There was a problem hiding this comment.
Can you update the tests on this module to use this option? While you are at it, can you also measure the time difference?
Thank you!
added 2 commits
February 11, 2019 15:42
License: MIT Signed-off-by: Alan Shaw <[email protected]>
License: MIT Signed-off-by: Alan Shaw <[email protected]>
Member
Author
|
Before: 4m8.412s |
License: MIT Signed-off-by: Alan Shaw <[email protected]>
daviddias
approved these changes
Feb 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs ipfs-inactive/js-ipfs-http-client#942