This repository was archived by the owner on Feb 12, 2024. It is now read-only.
Merged
Conversation
daviddias
approved these changes
Mar 20, 2017
daviddias
suggested changes
Mar 20, 2017
Member
daviddias
left a comment
daviddias
left a comment
There was a problem hiding this comment.
Seems that CI is not happy though, could you check?
https://travis-ci.org/ipfs/js-ipfs/jobs/212376202#L5943-L5963
src/cli/commands/files/add.js
Outdated
| originalPath: file.path | ||
| })), | ||
| pull.map((file) => ({ | ||
| path: wrapWithDirectory ? `${WRAPPER}${file.path}` : file.path, |
Member
There was a problem hiding this comment.
this should use path.join to ensure correct path separators
Contributor
Author
|
@diasdavid ya. extra space in the output :/ Fixed it 👍 @dignifiedquire Done 👍 |
daviddias
approved these changes
Mar 21, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #696