This repository was archived by the owner on Feb 12, 2024. It is now read-only.
fix(files.add): error on invalid input #782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dignifiedquire
approved these changes
Mar 9, 2017
Member
|
If this is something that should have the same error in the same condition in both js-ipfs as in js-ipfs-api, it would make sense for us to put tests for this in |
Member
Author
|
@victorbjelkholm correct thinking, it was in fact a test on interface-ipfs-core that caught it because that is where the test was added. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a new test added for js-ipfs-api that needed a fix here too.