Skip to content
This repository was archived by the owner on Feb 12, 2024. It is now read-only.

Conversation

@vasco-santos
Copy link
Member

After cids module update, the types build broke in js-ipfs with:

  Type '"thread"' is not assignable to type 'CodecName'.
104       pin.codec = multicodec.getNumber(cid.codec)
                                           ~~~~~~~~~
../ipfs-core/src/components/pin/pin-manager.js:141:40 - error TS2345: Argument of type '"path" | "identity" | "dns" | "cidv1" | "cidv2" | "cidv3" | "ip4" | "tcp" | "sha1" | "sha2-256" | "sha2-512" | "sha3-512" | "sha3-384" | "sha3-256" | "sha3-224" | "shake-128" | ... 443 more ... | "skynet-ns"' is not assignable to parameter of type 'CodecName'.
  Type '"thread"' is not assignable to type 'CodecName'.
141       pin.codec = multicodec.getNumber(cid.codec)
                                           ~~~~~~~~~
Found 2 errors.
Command failed with exit code 1: tsc --build /Users/vsantos/work/pl/gh/ipfs/js-ipfs/packages/ipfs-grpc-client/tsconfig-types.aegir.json

This PR updates the dependencies to make things consistent again

@vasco-santos vasco-santos force-pushed the chore/update-deps-to-fix-build branch from 9b8e35e to 98daaaa Compare March 3, 2021 09:41
@Gozala
Copy link
Contributor

Gozala commented Mar 4, 2021

I wanted to resolve remaining issues here so we could get this in. I have not managed to fix it, but it appears that we're encountering this issue parcel-bundler/parcel#5943

@Gozala
Copy link
Contributor

Gozala commented Mar 4, 2021

I wanted to resolve remaining issues here so we could get this in. I have not managed to fix it, but it appears that we're encountering this issue parcel-bundler/parcel#5943

Pushed a change that locks parcel-bundler to 1.12.3 to avoid that issue. It seems to fix the problem locally & I hope on CI, but I may not be around much longer to verify.

@vasco-santos
Copy link
Member Author

@hugomrdias was looking into the parcel issue yesterday. Not sure if he could get around it

@hugomrdias
Copy link
Member

It's fixed in another PR

@Gozala
Copy link
Contributor

Gozala commented Mar 4, 2021

It's fixed in another PR

Which one ?

@hugomrdias
Copy link
Member

hugomrdias commented Mar 4, 2021 via email

@achingbrain
Copy link
Member

Fixed by #3528

@achingbrain achingbrain closed this Mar 7, 2021
@achingbrain achingbrain deleted the chore/update-deps-to-fix-build branch March 7, 2021 13:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants