This repository was archived by the owner on Feb 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
chore: update deps to fix build #3579
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achingbrain
suggested changes
Mar 3, 2021
vasco-santos
commented
Mar 3, 2021
vasco-santos
commented
Mar 3, 2021
9b8e35e to
98daaaa
Compare
Contributor
|
I wanted to resolve remaining issues here so we could get this in. I have not managed to fix it, but it appears that we're encountering this issue parcel-bundler/parcel#5943 |
Contributor
Pushed a change that locks parcel-bundler to 1.12.3 to avoid that issue. It seems to fix the problem locally & I hope on CI, but I may not be around much longer to verify. |
Member
Author
|
@hugomrdias was looking into the parcel issue yesterday. Not sure if he could get around it |
Member
|
It's fixed in another PR |
Contributor
Which one ? |
Member
|
#3528
Hugo Dias
Web Engineer / Moxy
hugodias.me
+351 932 219 810
<https://twitter.com/hugomrdias>
<https://linkedin.com/in/hugomrdias>
<https://github.com/hugomrdias>
…On Thu, Mar 4, 2021 at 7:54 PM Irakli Gozalishvili ***@***.***> wrote:
It's fixed in another PR
Which one ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3579 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACMWTSQCRWNCPDOG7J3OU3TB7QOLANCNFSM4YQ3YXIQ>
.
|
Member
|
Fixed by #3528 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After
cidsmodule update, the types build broke injs-ipfswith:This PR updates the dependencies to make things consistent again