This repository was archived by the owner on Feb 12, 2024. It is now read-only.
chore: fixed cid and multicodec versions#3445
Merged
achingbrain merged 3 commits intomasterfrom Dec 14, 2020
Merged
Conversation
Member
Author
|
@achingbrain bundle size has increased a bit. Should I increase it in the PR? |
6 tasks
Member
Yes please, otherwise it'll break master. |
achingbrain
approved these changes
Dec 14, 2020
vasco-santos
pushed a commit
that referenced
this pull request
Dec 16, 2020
This reverts commit eceb0d4.
vasco-santos
pushed a commit
that referenced
this pull request
Dec 16, 2020
This reverts commit eceb0d4.
SgtPooki
referenced
this pull request
in ipfs/js-kubo-rpc-client
Aug 18, 2022
This PR sets fixed versions for cid and multicodec prior to their types PR being merged. These updates lead to a few regressions that should be fixed for updating these deps Context: - ipfs/js-ipfs#3442 - Some follow up breaking changes will probably land multiformats/js-multicodec#73
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR sets fixed versions for cid and multicodec prior to their types PR being merged. These updates lead to a few regressions that should be fixed for updating these deps
Context: