Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

fix: types path for ipfs-core #3356

Merged
merged 2 commits into from
Oct 28, 2020
Merged

fix: types path for ipfs-core #3356

merged 2 commits into from
Oct 28, 2020

Conversation

achingbrain
Copy link
Member

For some reason you need to add /src after ipfs-core otherwise the import in the generated index.d.ts has the wrong path.

Must fix properly before the next release.

For some reason you need to add `/src` after `ipfs-core` otherwise
the import in the generated `index.d.ts` has the wrong path.

Must fix properly before the next release.
packages/ipfs/src/index.js Show resolved Hide resolved
Add TODO

Co-authored-by: Irakli Gozalishvili <[email protected]>
@achingbrain achingbrain merged commit a6bcad5 into master Oct 28, 2020
@achingbrain achingbrain deleted the fix/types-path branch October 28, 2020 12:31
achingbrain added a commit that referenced this pull request Nov 2, 2020
1. addresses #3356 in a different way based no findings in #3358. 
2. Adds ts project example that uses ipfs and tests that it type checks.
3. Adds js project example that uses ipfs and runs type checker to ensure types are picked up and inferred.
4. Changes all the `ReturnType<import(...)>`'s to `ReturnType<typeof import(...)>` as former seems to raise errors in stricter TS setup.

Co-authored-by: achingbrain <[email protected]>
SgtPooki referenced this pull request in ipfs/js-kubo-rpc-client Aug 18, 2022
1. addresses #3356 in a different way based no findings in #3358. 
2. Adds ts project example that uses ipfs and tests that it type checks.
3. Adds js project example that uses ipfs and runs type checker to ensure types are picked up and inferred.
4. Changes all the `ReturnType<import(...)>`'s to `ReturnType<typeof import(...)>` as former seems to raise errors in stricter TS setup.

Co-authored-by: achingbrain <[email protected]>
@github-actions github-actions bot mentioned this pull request Sep 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants