This repository was archived by the owner on Feb 12, 2024. It is now read-only.
fix(http-client): allow stream option to be overridden#3205
Merged
achingbrain merged 1 commit intomasterfrom Aug 4, 2020
Merged
fix(http-client): allow stream option to be overridden#3205achingbrain merged 1 commit intomasterfrom
achingbrain merged 1 commit intomasterfrom
Conversation
achingbrain
approved these changes
Aug 4, 2020
SgtPooki
referenced
this pull request
in ipfs/js-kubo-rpc-client
Aug 18, 2022
`stream: true` was being set after the options were decapsulated. This makes it impossible to override streaming in the http api.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stream: truewas being set after the options were decapsulated. This makes it impossible to override streaming in the http api.