Skip to content
This repository was archived by the owner on Feb 12, 2024. It is now read-only.

fix: add charset to script tag#2653

Closed
achingbrain wants to merge 2 commits intomasterfrom
add-charset-to-script-tag
Closed

fix: add charset to script tag#2653
achingbrain wants to merge 2 commits intomasterfrom
add-charset-to-script-tag

Conversation

@achingbrain
Copy link
Member

Maybe might fix the build?

@achingbrain
Copy link
Member Author

achingbrain commented Dec 5, 2019

image

*shakes fist at bundlesize*

@achingbrain
Copy link
Member Author

achingbrain commented Dec 5, 2019

Seems to fix breakage caused by this line. Though the breakage was introduced by a libp2p-delegated-content-routing upgrade which doesn't seem related but it does go away if you downgrade that dep. But that's not a solution. Only forward, eh? 🤷‍♂

@alanshaw
Copy link
Member

alanshaw commented Dec 5, 2019

urgh, that dep was added to the client in v40 which is now being used in the delegated routing module.

@achingbrain
Copy link
Member Author

I noticed that, but this module has had builds pass with the v40 rpc client which would have pulled that dep into the tree. I guess it could it have been dead code elimination in the browser bundle or something?

@achingbrain achingbrain requested a review from alanshaw December 5, 2019 20:32
@achingbrain
Copy link
Member Author

A better fix: jkroso/parse-duration#11

@alanshaw
Copy link
Member

alanshaw commented Dec 9, 2019

Unnecessary now :)

@alanshaw alanshaw closed this Dec 9, 2019
@alanshaw alanshaw deleted the add-charset-to-script-tag branch December 9, 2019 20:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants