Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

[WIP] feat: integration of tool for repo migration #2044

Closed
wants to merge 6 commits into from

Conversation

AuHau
Copy link
Member

@AuHau AuHau commented May 11, 2019

Integrating https://github.com/AuHau/js-ipfs-repo-migrations/ for repo's migration.

The PR adds a new config option repoDisableAutoMigration that controls if the migration should be automatically applied or not.

TODO

  • Integrate ipfs-repo-migrations
  • Write tests
  • Documentation of migrations
  • Add proper package name when js-ipfs-repo-migrations is released on npm

Problems

  1. As the migration is part of the booting sequence, if a user wants to disable the auto-migrations to prevent applying new migrations using CLI js-ipfs config --bool repoDisableAutoMigration true, then the migrations are applied before turning off the migration mechanism.

Questions

  1. If repo's version is higher then expected, should initialization fail or just log this state (current approach)?

@AuHau
Copy link
Member Author

AuHau commented May 11, 2019

Should there be also an option for const node = new IPFS(options) to disable migrations or config value is sufficient?

@AuHau AuHau force-pushed the feat/repo-migrations branch 2 times, most recently from 338049e to 1d22f13 Compare May 16, 2019 17:10
@AuHau AuHau force-pushed the feat/repo-migrations branch 2 times, most recently from 192edf2 to 56116e6 Compare May 22, 2019 02:02
@AuHau AuHau changed the title [WIP] feat: integration of tool for repo migration feat: integration of tool for repo migration May 22, 2019
@AuHau
Copy link
Member Author

AuHau commented May 22, 2019

So the PR is ready for review.

The build is failing on npm install because of the dependency on the async/await refactors PRs.

package.json Outdated Show resolved Hide resolved
@alanshaw alanshaw requested a review from dirkmc May 29, 2019 15:56
AuHau and others added 4 commits June 27, 2019 11:05
The integration respect config's setting repoDisableAutoMigration that
defines if migrations should be automatically applied or not.

License: MIT
Signed-off-by: Adam Uhlir <[email protected]>
License: MIT
Signed-off-by: Adam Uhlir <[email protected]>
License: MIT
Signed-off-by: Adam Uhlir <[email protected]>
@AuHau
Copy link
Member Author

AuHau commented Jun 28, 2019

I have updated the PR as I have moved the integration directly to js-ipfs-repo to ipfs/js-ipfs-repo#202

@alanshaw alanshaw changed the title feat: integration of tool for repo migration [WIP] feat: integration of tool for repo migration Jul 15, 2019
@AuHau
Copy link
Member Author

AuHau commented Aug 6, 2019

Currently waiting for integration of async/await version of js-ipfs-repo as part of #1670. Not sure I will take a bite on that.

@AuHau
Copy link
Member Author

AuHau commented Oct 10, 2019

Replaced with #2527

@AuHau AuHau closed this Oct 10, 2019
alanshaw pushed a commit that referenced this pull request Nov 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants