Skip to content
This repository was archived by the owner on Feb 12, 2024. It is now read-only.

feat: use class-is for type checks#1310

Merged
daviddias merged 1 commit into
masterfrom
feat/use-class-is-for-type-checks
Apr 14, 2018
Merged

feat: use class-is for type checks#1310
daviddias merged 1 commit into
masterfrom
feat/use-class-is-for-type-checks

Conversation

@fsdiogo
Copy link
Copy Markdown
Contributor

@fsdiogo fsdiogo commented Apr 13, 2018

Some tests are failing due to #1178, but it seems work is being done to fix that.

After this PR is merged and released, ipfsd-ctl needs to update its ipfs devDep so it can pass the tests (I've tested it locally and all tests pass).

@fsdiogo fsdiogo self-assigned this Apr 13, 2018
@fsdiogo fsdiogo requested a review from daviddias April 13, 2018 15:01
@ghost ghost added the status/in-progress In progress label Apr 13, 2018
Copy link
Copy Markdown
Member

@daviddias daviddias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM \o/

@daviddias daviddias merged commit 5b2cf8c into master Apr 14, 2018
@ghost ghost removed the status/in-progress In progress label Apr 14, 2018
@daviddias daviddias deleted the feat/use-class-is-for-type-checks branch April 14, 2018 00:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants