This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
fix: Add ipfs path to cli help #1302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
vasco-santos
force-pushed
the
fix_add-ipfs-path-to-cli-help
branch
from
cd9cc1b
to
6bd42e0
Compare
vmx
reviewed
Apr 9, 2018
src/cli/utils.js
Outdated
| @@ -111,3 +111,7 @@ exports.rightpad = (val, n) => { | |||
| } | |||
| return result | |||
| } | |||
|
|
|||
| exports.ipfsPathHelp = 'ipfs uses a repository in the local file system. By default, the repo is ' + | |||
| 'located at ~/.jsipfs.To change the repo location, set the $IPFS_PATH environment variable:\n\n' + | |||
There was a problem hiding this comment.
Missing whitespace between ~/.jsipfs. and To change.
vasco-santos
force-pushed
the
fix_add-ipfs-path-to-cli-help
branch
from
6bd42e0
to
af8200d
Compare
daviddias
approved these changes
Apr 14, 2018
There was a problem hiding this comment.
Thank you for shipping this @vasco-santos and thanks for reviewing @vmx ❤️
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aiming to have a consistent menu with
go-ipfs, I added theIPFS_PATHas it is presented in Go implementation.In PR #1274, it was added to
jsipfs init --help, but it was presented before the options description, instead of in the end.In this solution, I changed the previous implementation. Using
yargs epilog, I added theIPFS_PATHmessage to the epilogue which is displayed for the following cases:jsipfsjsipfs --helpjsipfs init --helpjsipfs daemon --helpCloses #1213