This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
fix: disable WebRTC by default and add how to support it + websocket-star to the FAQ #1111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Codecov Report
@@ Coverage Diff @@
## master #1111 +/- ##
==========================================
- Coverage 83.49% 83.48% -0.02%
==========================================
Files 121 121
Lines 2726 2724 -2
==========================================
- Hits 2276 2274 -2
Misses 450 450
Continue to review full report at Codecov.
|
daviddias
commented
Nov 27, 2017
| @@ -344,7 +369,7 @@ const node = new IPFS({ | |||
| Swarm: [ | |||
| "/ip4/0.0.0.0/tcp/4002", | |||
| "/ip4/127.0.0.1/tcp/4003/ws", | |||
| "/dns4/star-signal.cloud.ipfs.team/wss/p2p-webrtc-star" | |||
| "/dns4/wrtc-star.discovery.libp2p.io/wss/p2p-webrtc-star" | |||
There was a problem hiding this comment.
Waiting on libp2p/js-libp2p-webrtc-star#126
daviddias
commented
Nov 27, 2017
| config: { | ||
| Addresses: { | ||
| Swarm: [ | ||
| '/dns4/ws-star.discovery.libp2p.io/wss/p2p-websocket-star' |
There was a problem hiding this comment.
Waiting on libp2p/js-libp2p-websocket-star-rendezvous#9
daviddias
changed the title
daviddias
force-pushed
the
disable-webrtc-by-default
branch
from
16ec3ea
to
979af0e
Compare
patrickdet
reviewed
Nov 27, 2017
README.md
Outdated
| @@ -398,6 +417,33 @@ const node = new IPFS({ | |||
|
|
|||
| The code above assumes you are running a local `signaling server` on port `9090`. Provide the correct values accordingly. | |||
|
|
|||
| #### Is there a more stable alternative to websocket-star that offers a similar functionality? | |||
There was a problem hiding this comment.
good catch, thank you :)
|
Validated that websocket-star is indeed working with the newly deployed rendezvous point by @victorbjelkholm, great job! |
daviddias
force-pushed
the
disable-webrtc-by-default
branch
from
ad360b9
to
cfdf1a2
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.