This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
Babel #1064
Closed
Babel #1064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually the built lib generates this error: |
daviddias
suggested changes
Nov 23, 2017
| @@ -19,6 +19,7 @@ | |||
| "npm": ">=3.0.0" | |||
| }, | |||
| "scripts": { | |||
| "babel": "babel dist -d lib", | |||
There was a problem hiding this comment.
Could this create a a file to dist/index.es5.js instead?
|
Just want to point out that @fazo96 provided some good intel on how to work around the fact that uglify2 doesn't support ES6, check it here #938 (comment) |
|
Closing this one, see for more details. #1321 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will resolve #938 , multiformats/js-cid#38 and multiformats/js-cid#42
TODO:
Add this to the Travis pipeline and expose it as the final build for other module to import.