This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
fix: typedef resolution & add examples that use types #3359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achingbrain
suggested changes
Oct 28, 2020
There was a problem hiding this comment.
The examples both need a README.md to describe them.
You can crib from the READMEs in the other examples but they need to:
- Give the name of the example
- A one-sentence overview of what the example shows
- Any install instructions
- How to run the example
- What output they should expect to see
- What files they can edit or next steps to take to play with the example
achingbrain
reviewed
Oct 28, 2020
achingbrain
reviewed
Oct 28, 2020
achingbrain
approved these changes
Nov 2, 2020
achingbrain
changed the title
SgtPooki
referenced
this pull request
in ipfs/js-kubo-rpc-client
Aug 18, 2022
1. addresses #3356 in a different way based no findings in #3358. 2. Adds ts project example that uses ipfs and tests that it type checks. 3. Adds js project example that uses ipfs and runs type checker to ensure types are picked up and inferred. 4. Changes all the `ReturnType<import(...)>`'s to `ReturnType<typeof import(...)>` as former seems to raise errors in stricter TS setup. Co-authored-by: achingbrain <[email protected]>
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request does following:
ReturnType<import(...)>'s toReturnType<typeof import(...)>as former seems to raise errors in stricter TS setup.