code cleanup and dead code removal #280
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'readable' is not an own property. and there is no 'writable'
node.js has native fetch for a while now. it just doesn't have native XMLHttpRequest.
a ReadableStream is an AsyncIterable now, so this block is never run. TypeScript realizes this, giving source the 'never' type.
The old version of lilconfig in use by rn-test only supports .js and .cjs extensions, not .mjs, in its getDefaultSearchPlaces() function. Only v3.1.0 and newer has .mjs. antonk52/lilconfig@4d104d6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the library can be converted to ESM #266, it needs a bunch of these changes first.
Switching to ESM format seems to allow TypeScript (during
npm run build) to notice a lot more type errors.Closes #216 (by removing
native-fetchand other unneeded packages)Closes #154 , sort of (consolidates node and browser
fetchinto one file;fetch-rn.jsstill exists)