This repository was archived by the owner on Oct 1, 2021. It is now read-only.
feat: report migration progress #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the `onProgress` option to receive feedback on how far each migration has progressed with a percent complete indicator and a message to show the user. If an `onProgress` option is passed, migrations will get a bit slower as we need to calculate the total volume of work before starting a migration in order to work out the percent complete. Also removes datastores from runtime dependencies as these should only ever be passed in as config. Fixes #32 BREAKING CHANGES: - The signature of the `onProgress` callback has changed
achingbrain
changed the title
Member
Author
|
I've merged this to unblock other work, please leave comments anyway and I can address feedback in a follow up PR |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the
onProgressoption to receive feedback on how far eachmigration has progressed with a percent complete indicator and a
message to show the user.
If an
onProgressoption is passed, migrations will get a bit sloweras we need to calculate the total volume of work before starting a
migration in order to work out the percent complete.
Also removes datastores from runtime dependencies as these should only
ever be passed in as config and consolidates the various ways of
creating a datastore from the config.
Fixes #32
BREAKING CHANGES:
onProgresscallback has changed