chore: Upgrade github.com/ipfs/go-ds-pebble to v0.5.1 for Go 1.25 support#177
chore: Upgrade github.com/ipfs/go-ds-pebble to v0.5.1 for Go 1.25 support#177stefanb wants to merge 2 commits intoipfs:masterfrom stefanb:go1.25
Conversation
Go 1.25 incompatibility detected in * Homebrew/homebrew-core#226636 then: * reported upstream in cockroachdb/swiss#48 * fixed upstream cockroachdb/swiss#49 This PR brings just this upstream fix upstream to ipfs. Alternatively we could wait until * ipfs/kubo#10850 is merged and released an then upgrade the `github.com/ipfs/kubo` direct dependancy. --- Before: go1.25rc1 build ./... github.com/cockroachdb/swiss # github.com/cockroachdb/swiss ../../../go/pkg/mod/github.com/cockroachdb/swiss@v0.0.0-20250327203710-2932b022f6df/map.go:286:7: undefined: hashFn ../../../go/pkg/mod/github.com/cockroachdb/swiss@v0.0.0-20250327203710-2932b022f6df/map.go:337:14: undefined: getRuntimeHasher ../../../go/pkg/mod/github.com/cockroachdb/swiss@v0.0.0-20250327203710-2932b022f6df/map.go:338:22: undefined: fastrand64 ../../../go/pkg/mod/github.com/cockroachdb/swiss@v0.0.0-20250327203710-2932b022f6df/map.go:600:23: undefined: fastrand64 ../../../go/pkg/mod/github.com/cockroachdb/swiss@v0.0.0-20250327203710-2932b022f6df/map.go:649:19: undefined: fastrand64 ../../../go/pkg/mod/github.com/cockroachdb/swiss@v0.0.0-20250327203710-2932b022f6df/map.go:670:20: undefined: fastrand64 ../../../go/pkg/mod/github.com/cockroachdb/swiss@v0.0.0-20250327203710-2932b022f6df/options.go:30:14: undefined: hashFn Upgrade: go get -u github.com/cockroachdb/swiss && go mod tidy go: upgraded github.com/cockroachdb/swiss v0.0.0-20250327203710-2932b022f6df => v0.0.0-20250624142022-d6e517c1d961 After: go1.25rc1 build ./... (build successful)
|
Thank you for submitting this PR!
Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. |
gammazero
left a comment
There was a problem hiding this comment.
Please update to use go-ds-pebble v0.5.1 or wait until kubo v0.36.0 is released and then depend on that.
|
After merging please don't forget to make a release before or right after go 1.25 is released in August (rc2 is expected on tuesday, July 8th). |
|
I would prefer to wait until the next kubo release to create a new release of ipget. That should be very soon. |
|
Triage note:
|
|
Thank you. This was handled as part of the upgrade to teh new version of kubo. Replaced by #178 |
Go 1.25 incompatibility detected in
then:
This PR brings just this upstream fix upstream to ipget by bubbling up through
Details:
Before:
After:
(build successful)