-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Files: video/image bytes are loaded twice on preview page #2217
Comments
#2218 is resolved, but this one is still the case in v4.3.0. This is extra bad for videos, which are fetched entirely: I think the problem is and then used in If you add a big text file, only small chunk is rendered, and then you can click "load more" to read the rest, but the browser already fetched the thing via We could fix this, by doing I propose:
I will open PR with fix later today. |
## [4.3.1](v4.3.0...v4.3.1) (2024-09-23) CID `bafybeideglc722hiwhsy4kiyl2fivf5lr6wozy2iuixtgzkvl3v4hasaty` --- ### Bug Fixes * **file-preview:** safeSubresourceGwUrl ([#2253](#2253)) ([bb861a3](bb861a3)), closes [/github.com//issues/2246#issuecomment-2322192398](https://github.com/ipfs//github.com/ipfs/ipfs-webui/issues/2246/issues/issuecomment-2322192398) * **files:** avoid duplicated fetch during preview ([#2254](#2254)) ([eefae25](eefae25)), closes [#2217](#2217) * **files:** prefer subdomain gw in copied share links ([#2255](#2255)) ([e8c4421](e8c4421)) ### Trivial Changes * .io → .tech ([b9f622d](b9f622d)) * browserslist@latest ([#2251](#2251)) ([809c55a](809c55a)) * Pull transifex translations ([#2258](#2258)) ([2250374](2250374)) * use [email protected] ([#2257](#2257)) ([99ba9ac](99ba9ac))
🎉 This issue has been resolved in version 4.3.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Tested on
webui.ipfs.io
andhttp://127.0.0.1:5001/webui/
, Firefox 124.0.2 and Google Chrome 124.0.6367.18.Opening image in Files triggers fetch twice
/api/v0/cat
cid.ipfs.localhost:port
I guess we had code somewhere which should try one, and then fallback to other, but instead does both?
There is also unrelated(?) bug in Chrome where the gateway GET listed here fails (#2218)
The text was updated successfully, but these errors were encountered: