feat: handle errors better

[hacdias]

If an error occurs while Electron is getting ready, we just show up a dialog telling that. There isn't much we can do. On the other hand, if the error happens during the execution of IPFS Desktop itself, we will have this error message:

The first option clearly opens the logs directory. The second option opens an URL to an issue pre-filled with the details of the error, like this:

This was something we didn't have in the last version, but we need to improve a lot: error handling! This will catch any major errors that might not be caught in other parts of the app.

License: MIT
Signed-off-by: Henrique Dias hacdias@gmail.com

[lidel]

cc ipfs/ipfs-webui#774 (Opt-in error reporting and anonymous usage reporting)

I really like like the "opt-in" for creating github issue with error pre-filled, extremely useful!
It is a last resort, but at least gives the next step to the user and shows we care about improving 👍

Small asks in comments inline below.

[lidel]

The label could be more inviting and explicit on what will happen on click:

Suggested change

	'Create a new issue'
	'Help us fixing it by creating a new issue with error details'

[hacdias]

The only regards I have here is that it is the name of a button. We are lucky they're big on Windows, but I have no clue how they'll look around the other OSes.

[lidel]

Good point. I tested how it looks on Linux:

Not the prettiest, but also not the end of the world:

Perhaps something like Report this issue to (IPFS) developers is a good compromise?

[olizilla]

A proposal for a more human friendly error message

The idea here is to

• Clearly state the situation "IPFS Desktop has shutdown..."
• Show just the error message, to give them something.
• Hide the stack trace behind the collapsed details section. It's not much use to the end user.
• Focus more on next steps.
• Remove "open the logs" It's useful for devs, but not so much for users.

Of note, the github report thing is cool, but if you are not a github user and signed in, you'll be hit with a log-in / sign-up prompt, so we may want to let the user know that requirement before sending them off to report the error...

[hacdias]

Now it's like this:

[lidel]

Raw Linux (without DE) looks fine too 👍

[lidel]

Something of note, app.getVersion returns electron version instead of one from package.json field:

It seems to be a known issue (electron/electron#7085) when running development version from a subdirectory (./src/) and should be fine in release build (which uses ./), but would be good to fix it in dev in case someone builds it by hand.

[hacdias]

@lidel building by hand, i.e., npm run build will give you the correct value. Only if you run it directly with npm start you'll be given Electron's version. We could though read package.json file directly. What do you think?

[hacdias]

@lidel I'm merging this now. We can take a look at that detail later.