Merged
Conversation
This issue relies on brittle scripts which break over time and degrade user experience. It also introduces maintenance overhead which we don't have bandwidth to deal with. This change keeps the feature enabled for existing users, but will hide menu item for new users, so it is phased out over time. License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
This was referenced Feb 23, 2021
Closed
Closed
This was referenced Jan 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"ipfs-on-path" opt-in feature aims to add
ipfsbinary toPATHon every platform.Unfortunately that is brittle, buggy, way better if user does this by hand for now.
We have a bunch of creative hacks that make it work most of the time, but after looking how we do it, I don't feel comfortable keeping this as a feature:
👉 This PR keeps the feature enabled for existing users, but will hide menu item for new users, so it is phased out over time. If you want
ipfson yourPATHfollow https://docs.ipfs.io/install/command-line/Just to illustrate, issues caused by ipfs-on-path:
#1357
#1301
#1761
#1694
#1755