Tweak title of npm on ipfs preference#1742
Merged
lidel merged 2 commits intoipfs:masterfrom Jan 25, 2021
andrew:install-npm-on-ipfs
Merged
Tweak title of npm on ipfs preference#1742lidel merged 2 commits intoipfs:masterfrom andrew:install-npm-on-ipfs
lidel merged 2 commits intoipfs:masterfrom
andrew:install-npm-on-ipfs
Conversation
jessicaschilling
approved these changes
Jan 22, 2021
Contributor
jessicaschilling
left a comment
jessicaschilling
left a comment
There was a problem hiding this comment.
LGTM but I'll defer to @lidel for OK/merging 😊
lidel
requested changes
Jan 22, 2021
Member
lidel
left a comment
lidel
left a comment
There was a problem hiding this comment.
Given this is a toggle checkbox which installs/uninstalls, and other Experiments start with Enable, can we do the same? 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As requested by @jessicaschilling in #1739 (comment)