Skip to content

feat: disable/enable gc via settings menu#1740

Merged
lidel merged 2 commits intoipfs:masterfrom
andrew:automatic-gc-setting
Jan 25, 2021
Merged

feat: disable/enable gc via settings menu#1740
lidel merged 2 commits intoipfs:masterfrom
andrew:automatic-gc-setting

Conversation

@andrew
Copy link
Contributor

@andrew andrew commented Jan 20, 2021

Closes #1647 (now that #1735 has been merged)

Very similar approach to #1735

Screenshot 2021-01-20 at 16 21 01

Part of #1647

Very similar approach to #1735
@jessicaschilling
Copy link
Contributor

@lidel, for your review 😊

- setting default state to on for new and pre-existing config
- remove keysize (not needed since go-ipfs 0.7.0 uses ED25519 keys by
  default)

License: MIT
Signed-off-by: Marcin Rataj <lidel@lidel.org>
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andrew!

Made small tweaks:

  • added migration setting default state to active for new and pre-existing config
  • removed keysize (not needed since go-ipfs 0.7.0 uses ED25519 keys by default)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Menu items for enabling pubsub and automatic GC

3 participants