Explicitly specify content-type in prompt template#1729
Merged
jessicaschilling merged 2 commits intomasterfrom Jan 8, 2021
Merged
Explicitly specify content-type in prompt template#1729jessicaschilling merged 2 commits intomasterfrom
jessicaschilling merged 2 commits intomasterfrom
Conversation
|
Thank you for fixing it! |
lidel
approved these changes
Jan 8, 2021
Member
lidel
left a comment
lidel
left a comment
There was a problem hiding this comment.
Tested on Linux, works as expected 👍
Feel free to merge with or without comment below :-)
Co-authored-by: Marcin Rataj <lidel@lidel.org>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1728.
This PR explicitly specifies
utf-8content-type in the template for the "Download..." dialog so non-roman languages don't blow out.Tested in Mac Big Sur only; would appreciate a look in Linux/Windows.
Before
After