Conversation
This ensures the CID is properly passed to copied link, and that filename is preserved when a single screen setup is used (produces single screenshot) License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
There was a problem hiding this comment.
Confirmed this works for me on Mac, including generating two separate files (Screen 1.png and Screen 2.png) for my multi-screen setup.
One nit: the directory names aren't super user-friendly, probably out of scope for this issue but just wanted to note it. (Just including zeros to confirm to YYYY-MM-DD and HH:MM would take care of that. Probably could omit seconds in the time, too.)

- month was -1 (because JS lol) - added padding and removed spaces for better-looking share URL License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
|
@jessicaschilling good catch. In IPFS Companion we use I've ported what we do in Companion as a starting point, let me know if anything should be tweaked:
|
|
@lidel Thank you! This sounds good. |

This ensures the CID is properly passed to copied link, and that filename is preserved when a single screen setup is used (produces single screenshot). Switched to reliable gateway, as share.ipfs.io is not maintained.
We also avoid low level pinning (MFS is enough) and ensure the produced CID is the same as on CLI (avoiding problems described in ipfs/ipfs-webui#676).