Merged
Conversation
Also, Closes #1530 License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
https://github.com/electron/governance/blob/master/wg-api/spec-documents/shell-openitem.md License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
This was referenced Oct 9, 2020
Contributor
Contributor
jessicaschilling
left a comment
jessicaschilling
left a comment
There was a problem hiding this comment.
Nice idea to include the version specificity for links out to GH. For the repo link, though, might not suggest linking to the readme directly - as it is rendered on the repo main page anyway, and the main page gives those who wish the opportunity to dig into the code straight away too.
#1687 (review) License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
Member
Author
|
That is fair. Restored the link to README in dfa8813 |
jessicaschilling
approved these changes
Oct 9, 2020
Contributor
jessicaschilling
left a comment
jessicaschilling
left a comment
There was a problem hiding this comment.
Confirmed that "Open [..] directory" works as expected.
rafaelramalho19
approved these changes
Oct 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
openItemwithopenPath(closes Advanced → "Open [..] directory" cause fatal crash #1676 & closes Auto-generated report: errors occurred upon startup #1677)necessary due to https://github.com/electron/governance/blob/master/wg-api/spec-documents/shell-openitem.md
Edit: also closes #1685, closes #1686, closes #1688.