Merged
Conversation
autoInstallOnAppQuit works fine on windows, but we had a bunch of code responsible for doing it manually due to macOS not being supported natively by autoInstallOnAppQuit. Due to this fix from #1679 was not applied correctly, and macOS-specific handling broke updates on windows. This change ensures that macOS keeps using the old upgrade paths, but Windows and AppImage leverage upstream code for applying upgrades. License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
lidel
force-pushed
the
fix/windows-update-install-on-quit
branch
from
b90d68b to
0544aff
Compare
Member
Author
|
Sadly this last mile is specific to our codebase and won't fix old versions. To properly test this we need to tag v0.13.1 and v0.13.2 and do quick smoke test by installing v0.13.1 and testing if it upgrades fine to v0.13.2.
|
Member
Author
|
Ok, tested this on Windows with my fork and both per user and per all users upgraded correctly on Windows. |
lidel
commented
Oct 9, 2020
Comment on lines
-114
to
-116
| e.preventDefault() | ||
| await stopIpfs() | ||
| app.quit() |
Member
Author
There was a problem hiding this comment.
not sure what was the purpose of e.preventDefault(), but it seemed to interfere with autoInstallOnAppQuit on Windows
hacdias
reviewed
Oct 9, 2020
License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
This was referenced Nov 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lidel/electron-updater-altschmerz#1 demonstrated that
autoInstallOnAppQuitworks fine on Windows, but we had a bunch of code responsible for doing it manually, probably due to macOS not being supported natively byautoInstallOnAppQuit.Docs for
electron-updater4.3.5 state:Due to this, the fix from #1679 was not applied correctly: macOS-specific handling executed first and broke updates on Windows.
This PR ensures that macOS keeps using the old upgrade paths, but Windows and AppImage leverage upstream code for applying upgrades.
Closes #1570 and most likely closes #1630 too.