fix: package.json, package-lock.json & .snyk to reduce vulnerabilities#1653
Closed
Kirobi92 wants to merge 1 commit intoipfs:masterfrom
Closed
fix: package.json, package-lock.json & .snyk to reduce vulnerabilities#1653Kirobi92 wants to merge 1 commit intoipfs:masterfrom
Kirobi92 wants to merge 1 commit intoipfs:masterfrom
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-I18NEXT-575536 - https://snyk.io/vuln/SNYK-JS-I18NEXT-585930 The following vulnerabilities are fixed with a Snyk patch: - https://snyk.io/vuln/SNYK-JS-LODASH-567746
Member
|
Thank you for submitting the PR, but I'm not able to merge it, because it introduces vendor-specific patching via a thirdparty tool. In IPFS repos we usually bump dependencies before each release, and have github dependency check enabled, so adding Snyk would only increase noise and bring the opposite effect. That being said, I may be wrong: let me know if I am missing some deeper point or added value here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following vulnerabilities are fixed with an upgrade:
The following vulnerabilities are fixed with a Snyk patch: