feat: go-ipfs v0.7.0 and ipfs-webui v2.11.2#1638
Merged
Conversation
Member
|
Ugh, I just realized this won't be an easy upgrade:
I did ipfsd-ctl update recently so it should be still fresh in my mind – I'll take a stab at updating and comment on this PR later. |
This removed go-ipfs-dep dependency and uses go-ipfs with the latest http-client and ipfsd-ctl License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
This comment has been minimized.
This comment has been minimized.
This removed go-ipfs-dep dependency and uses go-ipfs with the latest http-client and ipfsd-ctl License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
Removes code that's addressed by ipfs/ipfs-webui#1628
This is CID of webui from ipfs/ipfs-webui#1628 will be switched to release after patch one is tagged upstream License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
Do not build feature branch with open Pull Requests, should remove redundant appveyor job on PRs. License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
lidel
force-pushed
the
chore/bump-go-ipfs
branch
from
816d036 to
bd056b5
Compare
…sktop into chore/bump-go-ipfs
lidel
approved these changes
Sep 15, 2020
Member
lidel
left a comment
lidel
left a comment
There was a problem hiding this comment.
It is ready, thank you @rafaelramalho19 – we just wait for official 0.7.0 now.
(if you plan to do more dev in ipfs-desktop, it's ok to merge this as-is and then bump to non-RC version before release, if not, ok to park this until final release)
Switching to release version License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
lidel
changed the title
Member
|
@rafaelramalho19 I've bumped this PR to the release version of go-ipfs 0.7.0 and looks good on Linux. Mind building on mac and windows and confirming there are no surprises? |
|
@lidel I was wanting to use go-ipfs 0.7.0 with the desktop app on Mac, so I figured I'd do a Mac smoke test for you. Looks good!
Tested with Node 12.16.3 and 14.12.0. Running `npm ci` warnings with node 14.12.0:
|
rafaelramalho19
changed the title
Contributor
Author
|
@lidel v.2.11.2 is now on this PR 👌 |
lidel
requested changes
Sep 28, 2020
Member
There was a problem hiding this comment.
Looks good, but CI on macOS fails due to Apple notarization:
1 package(s) were not uploaded because they had problems:
/var/folders/17/5mc7816d3mndxjqgplq6057w0000gn/T/FCE68004-143C-41A9-8B85-08020C829FF0/io.ipfs.desktop.itmsp - Error Messages:
You must first sign the relevant contracts online. (1048)
2020-09-28 15:43:08.319 altool[4208:12324] *** Error: You must first sign the relevant contracts online. (1048)
Before this is merged we need to fix notarization so the CI is green.
Contributor
Author
|
@lidel all ready for final reviews 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc ipfs/kubo#7560
closes #1639 (by upgrading to webui v2.11.1)