This repository has been archived by the owner on Mar 25, 2022. It is now read-only.
gateway: add /refs/* #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
| set $proxyhost $host; | ||
| location /refs/ { | ||
| rewrite "^/refs/([^/]+)/([^/]+)/([^/]+)$" "/" break; | ||
| proxy_set_header Host $3.$2.$1.refs.ipfs.io; |
There was a problem hiding this comment.
this doesn't seem robust enough to also handle:
refs.ipfs.io
a.refs.ipfs.io
b.a.refs.ipfs.io
maybe we should just have one ipfs graph, with its root at refs.ipfs.io, redirect /refs/... to refs.ipfs.io, and it could handle $refs/a/b/c.
|
@lgierth am good to ship this if you dont have much time, but think we probably should leverage ipfs graphs to have a root at |
19 tasks
|
Ooh yep that's a lot simpler -- we'll just have one |
35 tasks
ghost
Rewrites requests for /refs/* to refs.ipfs.io/*. Also replaces conditionals with location directives, which are evaluated more efficiently. License: MIT Signed-off-by: Lars Gierth <[email protected]>
That's what it does now -- see https://ipfs.io/refs. We'll have to fix the gateway's directory listings once more :/ |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrites requests for
/refs/a/b/ctoc.b.a.refs.ipfs.io.Also replaces conditionals with location directives,
which are evaluated more efficiently.
Part of the gateway-dmca-denylist thing: ipfs/kubo#1551 https://github.com/ipfs/gateway-dmca-denylist