fix: Add GlobSourceResult to globSource return type in unixfs. #475
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
fix: Add GlobSourceResult to globSource return type.
Description
This is a small PR that modifies the return type on the
globSource
utility in@helia/unixfs
to return theGlobSourceResult
in addition to theImportCandidate
type. This means that thepath
property will be astring
instead ofstring | undefined
.Notes & open questions
This PR makes it a bit easier to use
globSource
since it is a bit annoying to have to check ifpath
is defined when it always is.Is there any reason why we had the
GlobSourceResult
type butglobSource
does not return it?Change checklist