Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: helia init should extend base helia init #464

Merged
merged 2 commits into from
Mar 12, 2024
Merged

fix: helia init should extend base helia init #464

merged 2 commits into from
Mar 12, 2024

Conversation

achingbrain
Copy link
Member

@achingbrain achingbrain commented Mar 12, 2024 •
edited
Loading

Similar to @helia/http's init interface extends that from @helia/utils, reduce the duplication in helia's init interface.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@achingbrain
fix: helia init should extend base helia init
77ed44a 
Similar to `@helia/http`'s init interface extends that from `@helia/utils`,
reduce the duplciation in `helia`'s init interface.
@achingbrain achingbrain requested a review from a team as a code owner March 12, 2024 08:03
@achingbrain achingbrain merged commit a64e5de into main Mar 12, 2024
18 checks passed
@achingbrain achingbrain deleted the fix/extend-helia-init branch March 12, 2024 10:54
@achingbrain achingbrain mentioned this pull request Mar 12, 2024
Merged
@SgtPooki SgtPooki mentioned this pull request Apr 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@achingbrain