Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: change cidv0 to cidv1 in the readme #105

Merged
merged 2 commits into from
Sep 21, 2024
Merged

docs: change cidv0 to cidv1 in the readme #105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f680551
change cidv0 to cidv1 in the readme
bjesus Sep 14, 2024
e876db3
also update the source code comments
bjesus Sep 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/verified-fetch/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,7 +522,7 @@ This module attempts to act as similarly to the `fetch()` API as possible.

This library supports the following methods of fetching web3 content from IPFS:

1. IPFS protocol: `ipfs://<cidv0>` & `ipfs://<cidv0>`
1. IPFS protocol: `ipfs://<cidv0>` & `ipfs://<cidv1>`
Copy link
Member

@2color 2color Sep 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update

helia-verified-fetch/packages/verified-fetch/src/index.ts

Line 496 in 3d8bb78

* 1. IPFS protocol: `ipfs://<cidv0>` & `ipfs://<cidv0>`
which is the source for the README.md which is generated.

2. IPNS protocol: `ipns://<peerId>` & `ipns://<publicKey>` & `ipns://<hostUri_Supporting_DnsLink_TxtRecords>`
3. CID instances: An actual CID instance `CID.parse('bafy...')`

Expand Down
2 changes: 1 addition & 1 deletion packages/verified-fetch/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,7 +493,7 @@
*
* This library supports the following methods of fetching web3 content from IPFS:
*
* 1. IPFS protocol: `ipfs://<cidv0>` & `ipfs://<cidv0>`
* 1. IPFS protocol: `ipfs://<cidv0>` & `ipfs://<cidv1>`
* 2. IPNS protocol: `ipns://<peerId>` & `ipns://<publicKey>` & `ipns://<hostUri_Supporting_DnsLink_TxtRecords>`
* 3. CID instances: An actual CID instance `CID.parse('bafy...')`
*
Expand Down
Loading