This repository has been archived by the owner on Jun 26, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 26
Commits on Dec 17, 2018
-
Unify the `string`/`ipld.Node` information a parent has about its children when updating a modified entry. This will be used to simplify the code around the `childCloser` interface and related logic.
Configuration menu - View commit details
-
Copy full SHA for 32ca97a - Browse repository at this point
Copy the full SHA 32ca97aView commit details -
Use newly introduced `child` structure whenever the logically tied `string`/`ipld.Node` pair was used to represent a child entry in a directory operation.
Configuration menu - View commit details
-
Copy full SHA for 54062f4 - Browse repository at this point
Copy the full SHA 54062f4View commit details -
rename the
childCloser
interfaceRename the `childCloser` interface to `mutableParent` to better reflect the fact that the structures that implement it (`Directory` and `Root`) have the function of parents in the MFS hierarchy. Rename also the method of the interface from `closeChild` to `updateChildEntry` shifting the focus away from in which circumstance is the method being called (when closing a child) to actually what operation is being performed by the method (updating an entry in the parent to the new content).
Configuration menu - View commit details
-
Copy full SHA for e87a272 - Browse repository at this point
Copy the full SHA e87a272View commit details -
Configuration menu - View commit details
-
Copy full SHA for ef5e119 - Browse repository at this point
Copy the full SHA ef5e119View commit details -
move
Republisher
to a separate fileExtract the `Republisher` structure and related logic from `system.go` (leaving that file mainly with the `Root` logic, and hence now renamed as `root.go`) to a new `repub.go` file. Even though the MFS root has support for republishing updates the logic behind those two structures is mostly decoupled, that should be reflected in the source code organization.
Configuration menu - View commit details
-
Copy full SHA for 8539b81 - Browse repository at this point
Copy the full SHA 8539b81View commit details -
remove
Sync
fromFileDescriptor
Remove the `Sync()` method from the `FileDescriptor` and also its implementation. Two different undocumented methods in `FileDescriptor` are offered to update the state of the MFS: `Flush()` and `Sync()`, both calling `updateChildEntry`. The only difference (the user is not aware of) is that one sets the `fullSync` argument and the other doesn't, that is, one does a full update of the filesystem and the other just updates the parent directory. This current situation is not clear to the consumer who may use one desiring the effect of the other. As a precautionary measure while redesigning the MFS API one method is removed to simplify its usage. The `Sync()` was chosen as the less "safe" alternative which didn't do a full update of the MFS and also doesn't seem to be used in the `go-ipfs` repository (the main consumer of the `mfs` package).
Configuration menu - View commit details
-
Copy full SHA for 2f52311 - Browse repository at this point
Copy the full SHA 2f52311View commit details -
Unify the two caches in `Directory` that discriminated between files and directories (`files` and `childDirs`) into a single `entriesCache` since that distinction wasn't used anywhere and made the code unnecessarily more complex.
Configuration menu - View commit details
-
Copy full SHA for 925c0a8 - Browse repository at this point
Copy the full SHA 925c0a8View commit details
Commits on Dec 19, 2018
-
Document the `Republisher` code in `repub.go` according to the explanation in ipfs/kubo#5092 (comment). Erring on the side of verbosity since this has been a part of the code with very little review up until now.
Configuration menu - View commit details
-
Copy full SHA for 0abe769 - Browse repository at this point
Copy the full SHA 0abe769View commit details -
rename all
Republisher
receiversUnify all the `Republisher` receivers names to `rp` (avoiding `r` to distinguish it from the `Root` receivers).
Configuration menu - View commit details
-
Copy full SHA for 4809106 - Browse repository at this point
Copy the full SHA 4809106View commit details -
rename the
mutableParent
interface to justparent
The name `mutableParent` signals "this is a mutable parent, there are immutable versions".
Configuration menu - View commit details
-
Copy full SHA for d1471da - Browse repository at this point
Copy the full SHA d1471daView commit details -
Configuration menu - View commit details
-
Copy full SHA for 25dd99b - Browse repository at this point
Copy the full SHA 25dd99bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c4a00a - Browse repository at this point
Copy the full SHA 6c4a00aView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.