This repository has been archived by the owner on Jun 26, 2023. It is now read-only.
feat(fsnode): add type helper #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schomatis
reviewed
Oct 19, 2018
mfs_test.go
Outdated
| } | ||
| } | ||
|
|
||
| func TestIsFile(t *testing.T) { |
There was a problem hiding this comment.
nit: could we merge this two test functions? or include a helper test function that would abstract all the boiler plate code of creating an MFS to experiment with? (I feel like this should exist already somewhere in this file.)
There was a problem hiding this comment.
@schomatis I had merged two test function. However, I think it is not a completed job, because the mfs_test.go objective and test style is not clear. If you don't mind, maybe we could merge this pr firstly and then fix this issue (#9)?
overbool
force-pushed
the
feat/add-type-helper
branch
from
815d4af
to
8c63df0
Compare
schomatis
approved these changes
Oct 22, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #22
(edit: remove the "fixes" tag to avoid closing the issue, we still need to incorporate these functions in the MFS clients.)