Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some performance regressions when reading protobuf nodes #34

Merged
merged 2 commits into from
Feb 28, 2019

Conversation

Stebalien
Copy link
Member

@Stebalien Stebalien commented Feb 27, 2019

This is also a bugfix as we don't want to re-encode nodes unless we change them. If we do and the user chose a non-standard encoding, we could change the CID. This is likely what triggered ipfs/kubo#6011

@ghost ghost assigned Stebalien Feb 27, 2019
@ghost ghost added the status/in-progress In progress label Feb 27, 2019
Copy link
Member

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Assuming it's passing go-ipfs tests

@Stebalien Stebalien merged commit de6f1da into master Feb 28, 2019
@Stebalien Stebalien deleted the fix/fast-read branch February 28, 2019 23:07
@ghost ghost removed the status/in-progress In progress label Feb 28, 2019
Jorropo pushed a commit to ipfs/boxo that referenced this pull request Mar 15, 2023
fix some performance regressions when reading protobuf nodes

This commit was moved from ipfs/go-merkledag@de6f1da
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants