Address review

License: MIT
Signed-off-by: Jakub Sztandera <[email protected]>

log.go

@@ -161,12 +161,9 @@ type EventLogger interface {
 
 // Logger retrieves an event logger by name
 func Logger(system string) *eventLogger {
-
-	// TODO if we would like to adjust log levels at run-time. Store this event
-	// logger in a map (just like the util.Logger impl)
 	if len(system) == 0 {
 		setuplog := getLogger("setup-logger")
-		setuplog.Warn("Missing name parameter")
+		setuplog.Error("Missing name parameter")
 		system = "undefined"
 	}
 

oldlog.go

@@ -59,16 +59,18 @@ var zapCfg = zap.NewProductionConfig()
 func SetupLogging() {
 
 	// colorful or plain
-
-	color := os.Getenv(envLoggingFmt) != "nocolor"
-	if color {
-		zapCfg.EncoderConfig.EncodeLevel = zapcore.CapitalColorLevelEncoder
-	} else {
+	switch os.Getenv(envLoggingFmt) {
+	case "nocolor":
+		zapCfg.Encoding = "console"
 		zapCfg.EncoderConfig.EncodeLevel = zapcore.CapitalLevelEncoder
+	case "json":
+		zapCfg.Encoding = "json"
+	default:
+		zapCfg.Encoding = "console"
+		zapCfg.EncoderConfig.EncodeLevel = zapcore.CapitalColorLevelEncoder
 	}
 
 	zapCfg.Sampling = nil
-	zapCfg.Encoding = "console"
 	zapCfg.EncoderConfig.EncodeTime = zapcore.ISO8601TimeEncoder
 
 	zapCfg.OutputPaths = []string{"stderr"}