Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unixfs get metric #6406

Merged
merged 3 commits into from
Jun 5, 2019
Merged

add unixfs get metric #6406

merged 3 commits into from
Jun 5, 2019

Conversation

whyrusleeping
Copy link
Member

This is a metric I really want to see, I don't know what labels we should add here, but I want to get this running on our gateway nodes ASAP.

@whyrusleeping
Copy link
Member Author

we should probably add tags to this, for things like "this is an ipns request" or "this is a path with N segments"

Copy link
Member

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. In future we might consider creating a metrics-collecting layer of CoreApi (I don't know how expensive collecting metrics is, so keeping it to the gateway for now seems to make sense)

@Stebalien
Copy link
Member

LGTM. In future we might consider creating a metrics-collecting layer of CoreApi (I don't know how expensive collecting metrics is, so keeping it to the gateway for now seems to make sense)

I started moving this logic there but we do some path resolution in the gateway before we call Get. But yeah, we should have metrics in both places.

@Stebalien Stebalien merged commit 1fd5f9d into master Jun 5, 2019
@Stebalien Stebalien deleted the feat/gateway-metric branch June 5, 2019 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants