-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plugin: add a daemon plugin with access to the CoreAPI #5955
Conversation
7594d28
to
bb15ee1
Compare
bb15ee1
to
31dfe52
Compare
|
||
(experimental) | ||
|
||
Tracer plugins allow injecting an opentracing backend into go-ipfs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Afaik there is a repo with this plugin somewhere, would be nice to have a link
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linked.
There's no reason for these to be exclusive. License: MIT Signed-off-by: Steven Allen <[email protected]>
This allows users to run multiple go-ipfs "clients" in-process. License: MIT Signed-off-by: Steven Allen <[email protected]>
License: MIT Signed-off-by: Steven Allen <[email protected]>
License: MIT Signed-off-by: Steven Allen <[email protected]>
803d765
to
45734eb
Compare
if err != nil { | ||
closePlugins(loader.plugins[i:]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is a bug. It should read loader.plugins[:i]
as all plugins before i
have been started not those after i
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be the case, do you mind sending a PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll send a PR.
fixes #5954