Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Generic" Plugin type(feature)? #5954

Closed
eyedeekay opened this issue Jan 29, 2019 · 2 comments · Fixed by #5955
Closed

"Generic" Plugin type(feature)? #5954

eyedeekay opened this issue Jan 29, 2019 · 2 comments · Fixed by #5955
Labels
kind/feature A new feature

Comments

@eyedeekay
Copy link

Version information:

go-ipfs version: 0.4.18-aefc746
Repo version: 7
System version: amd64/linux
Golang version: go1.11

Type:

Feature Request

Description:

I would like to be able to create a type of plugin which extends IPFS's functionality by connecting it to the API's of other applications automatically, in particular my use case is making the gateway available via tunnels and hidden services. The current plugin system requires that plugins implement one of the existing plugin interfaces, and implementing the hidden service listeners on top of the existing plugin interfaces is a pretty messy process. In our branch at https://github.com/rtradeltd/go-ipfs I have created a prototype of a "Generic" plugin interface which only requires implementing "plugin.Plugin" with an Exists() function that is intended to the return nil if the plugin was initialized correctly, and an error if something went wrong. If this is acceptable I'd like to submit it.

@Stebalien
Copy link
Member

How about something like: #5955? That way you don't even need to use the HTTP API?

@eyedeekay
Copy link
Author

eyedeekay commented Jan 29, 2019

How about something like: #5955? That way you don't even need to use the HTTP API?

Oh I hadn't seen that yet Because you just did it. That's awesome. To all appearances it fulfills what I need and much of what I will eventually need. If it doesn't I'll reopen. Thanks for your help :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature A new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants