Update IPTB test #5636
Merged
Update IPTB test #5636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
travisperson
force-pushed
the
feat/iptb-2
branch
from
498dbee
to
ef946ee
Compare
added 3 commits
November 1, 2018 19:33
Related to #5521 License: MIT Signed-off-by: Travis Person <[email protected]>
License: MIT Signed-off-by: Travis Person <[email protected]>
License: MIT Signed-off-by: Travis Person <[email protected]>
travisperson
force-pushed
the
feat/iptb-2
branch
from
33d3a12
to
ba2c8fc
Compare
License: MIT Signed-off-by: Travis Person <[email protected]>
travisperson
force-pushed
the
feat/iptb-2
branch
from
ba2c8fc
to
fcf1043
Compare
License: MIT Signed-off-by: Travis Person <[email protected]>
|
@Kubuxu if you want to take a look through this, I think it's ready for a review. /cc @Stebalien |
Stebalien
approved these changes
Nov 3, 2018
There was a problem hiding this comment.
We can bikeshed later, LGTM. The tests pass and I'm running a gx update and I really don't want to have to cut yet another "fake" IPTB release.
Nice job @travisperson!
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains a "unpublished" version of iptb v2. Just running tests in CI to make sure everything works (mostly around mount).
Related to #5521