feat: add dry-run flag for config profile apply command #5455

qiwaa · 2018-09-13T11:38:15Z

License: MIT
Signed-off-by: chenminjian [email protected]

Stebalien · 2018-09-13T20:39:27Z

Our CI needs to be able to fetch gx packages so some reachable IPFS node has to have them pinned locally (done).
Gx packages need to specify a dvcsImport path. Otherwise, path rewriting won't work. I've fixed up the gx packages so this should be fine now.

(basically, gx has a lot of rough edges we're working on ironing out).

Stebalien

Looking good but we'll definitely need some sharness tests. You'll probably want to add them to test/sharness/t0021-config.sh.

core/commands/config.go

qiwaa · 2018-09-14T08:33:04Z

@Stebalien Thanks for your guidance. I find that /elgris/jsondiff doesn't support unmarshal. Should I write a new jsondiff lib to support this feat?

Stebalien · 2018-09-14T16:26:23Z

Hm. I see. Well, we have two options:

Send a []jsondiff.Item array (by calling diff.Items()) and then reconstruct the diff using diff.Add on the client. I'm not a fan of this approach...
Send back the old config and the new config and do the diff on the client. Personally, I'd rather do this.

That is, send back ConfigUpdateOutput { Old: OldConfig, New: NewConfig } and call jsondiff on the client. Does that sound reasonable? That's probably the most flexible solution.

qiwaa · 2018-09-17T07:02:19Z

@Stebalien Thx. The second method looks great and I use it. Could you help me review my code again?

Stebalien · 2018-09-19T20:44:11Z

@schomatis in an effort to "spread the love", I'm assigning you to review 😄.

schomatis

Feeling the love 😬

core/commands/config.go

qiwaa · 2018-09-20T16:38:47Z

hey, @schomatis . I have completed modifications according to your advice. Could you help me review my code again? 😊

schomatis

Niiiiiicee, this is definitely much cleaner, thanks for taking the time to make those changes.

schomatis

Great, thanks!

qiwaa · 2018-10-09T02:44:26Z

@Stebalien Is there any other work that needs to be done? If so, please tell me.

Kubuxu

Hard blocking the PR.

We changed other config commands to stop exposing Identity.PrivKey over HTTP API for security reasons. This command will also need to do that.

schomatis · 2018-10-09T14:28:09Z

@Kubuxu Could you expand some more on that please? How is this PR impacting security?

Kubuxu · 2018-10-09T17:45:57Z

In the past we hardened config endpoints not to return Identity.PrivKey because it is possible to break CORS protection and access API endpoint in some browsers.

This would reintroduce this risk.

schomatis · 2018-10-10T02:20:57Z

Oh, I see, the newly added diff output could expose sensitive information, makes sense, thanks.

qiwaa · 2018-10-10T05:10:50Z

This is a good suggestion. Thx a lot. I have updated the pr to stop exposing Identity.PrivKey over HTTP API.

Kubuxu · 2018-10-10T14:36:11Z

Thanks for resolving it quickly.

This fixes the data-race in the config. Depends on: ipfs/go-ipfs-config#16. This does not fix #4942 as there's still a logical race: parallel config updates clobber each other. However, we'll still need the Clone function for the new `--dry-run` flag introduced in #5455. License: MIT Signed-off-by: Steven Allen <[email protected]>

Stebalien · 2018-10-23T17:10:32Z

Blocked on #5455, unfortunately.

Stebalien · 2018-10-23T17:10:54Z

(that is, the dereference isn't sufficient to actually clone the config).

qiwaa · 2018-10-24T02:57:07Z

Maybe dereference is sufficient. Because config.Transformer, which is transformConfig' parameter , just updates map' point, not map' content. This does not affect the global config. Does that make sense?

Stebalien · 2018-10-24T12:41:55Z

I see. Yeah, this should work... (well, shouldn't be any worse than it already is).

License: MIT Signed-off-by: chenminjian <[email protected]>

qiwaa · 2018-10-24T15:25:19Z

Hey, @Stebalien . Thx for your review. If you need a better jsondiff lib in the future, ping me please. I am sure I will do this well.

qiwaa requested a review from Kubuxu as a code owner September 13, 2018 11:38

ghost assigned Stebalien Sep 13, 2018

ghost added the status/in-progress In progress label Sep 13, 2018

Stebalien requested changes Sep 13, 2018

View reviewed changes

core/commands/config.go Show resolved Hide resolved

Stebalien reviewed Sep 13, 2018

View reviewed changes

core/commands/config.go Outdated Show resolved Hide resolved

Stebalien mentioned this pull request Sep 13, 2018

Show diff in 'config profile' commands, add dry-run flag #4923

Closed

Stebalien added the need/author-input Needs input from the original author label Sep 13, 2018

Stebalien removed the need/author-input Needs input from the original author label Sep 14, 2018

Stebalien requested a review from schomatis September 19, 2018 20:43

schomatis reviewed Sep 19, 2018

View reviewed changes

core/commands/config.go Show resolved Hide resolved

core/commands/config.go Outdated Show resolved Hide resolved

schomatis previously approved these changes Sep 21, 2018

View reviewed changes

schomatis added topic/repo Topic repo RFM and removed status/in-progress In progress labels Sep 21, 2018

qiwaa dismissed schomatis’s stale review via 82da864 October 2, 2018 14:38

schomatis approved these changes Oct 2, 2018

View reviewed changes

Kubuxu requested changes Oct 9, 2018

View reviewed changes

Kubuxu removed the RFM label Oct 9, 2018

schomatis added the topic/security Topic security label Oct 10, 2018

Kubuxu approved these changes Oct 10, 2018

View reviewed changes

Kubuxu added RFM and removed topic/repo Topic repo labels Oct 10, 2018

Kubuxu requested a review from Stebalien October 10, 2018 14:44

Stebalien mentioned this pull request Oct 23, 2018

fix config data race #5634

Merged

Stebalien added the status/blocked Unable to be worked further until needs are met label Oct 23, 2018

Stebalien removed the status/blocked Unable to be worked further until needs are met label Oct 24, 2018

chenminjian and others added 2 commits October 24, 2018 05:46

feat: add dry-run flag for config profile apply command

2e3cbe3

License: MIT Signed-off-by: chenminjian <[email protected]>

feat: stop apply command exposing private key over HTTP API

64cdabc

License: MIT Signed-off-by: chenminjian <[email protected]>

ghost added the status/in-progress In progress label Oct 24, 2018

Stebalien approved these changes Oct 24, 2018

View reviewed changes

Stebalien merged commit d3bba25 into ipfs:master Oct 24, 2018

ghost removed the status/in-progress In progress label Oct 24, 2018

qiwaa deleted the feat/flags/profile-apply branch October 27, 2018 03:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add dry-run flag for config profile apply command #5455

feat: add dry-run flag for config profile apply command #5455

qiwaa commented Sep 13, 2018 •

edited

Loading

Stebalien commented Sep 13, 2018

Stebalien left a comment

qiwaa commented Sep 14, 2018 •

edited

Loading

Stebalien commented Sep 14, 2018

qiwaa commented Sep 17, 2018 •

edited

Loading

Stebalien commented Sep 19, 2018

schomatis left a comment

qiwaa commented Sep 20, 2018

schomatis left a comment

schomatis left a comment

qiwaa commented Oct 9, 2018

Kubuxu left a comment •

edited

Loading

schomatis commented Oct 9, 2018

Kubuxu commented Oct 9, 2018

schomatis commented Oct 10, 2018

qiwaa commented Oct 10, 2018

Kubuxu commented Oct 10, 2018

Stebalien commented Oct 23, 2018

Stebalien commented Oct 23, 2018

qiwaa commented Oct 24, 2018

Stebalien commented Oct 24, 2018

qiwaa commented Oct 24, 2018

feat: add dry-run flag for config profile apply command #5455

feat: add dry-run flag for config profile apply command #5455

Conversation

qiwaa commented Sep 13, 2018 • edited Loading

Stebalien commented Sep 13, 2018

Stebalien left a comment

Choose a reason for hiding this comment

qiwaa commented Sep 14, 2018 • edited Loading

Stebalien commented Sep 14, 2018

qiwaa commented Sep 17, 2018 • edited Loading

Stebalien commented Sep 19, 2018

schomatis left a comment

Choose a reason for hiding this comment

qiwaa commented Sep 20, 2018

schomatis left a comment

Choose a reason for hiding this comment

schomatis left a comment

Choose a reason for hiding this comment

qiwaa commented Oct 9, 2018

Kubuxu left a comment • edited Loading

Choose a reason for hiding this comment

schomatis commented Oct 9, 2018

Kubuxu commented Oct 9, 2018

schomatis commented Oct 10, 2018

qiwaa commented Oct 10, 2018

Kubuxu commented Oct 10, 2018

Stebalien commented Oct 23, 2018

Stebalien commented Oct 23, 2018

qiwaa commented Oct 24, 2018

Stebalien commented Oct 24, 2018

qiwaa commented Oct 24, 2018

qiwaa commented Sep 13, 2018 •

edited

Loading

qiwaa commented Sep 14, 2018 •

edited

Loading

qiwaa commented Sep 17, 2018 •

edited

Loading

Kubuxu left a comment •

edited

Loading