Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build on DragonFlyBSD #5031

Merged
merged 1 commit into from
May 24, 2018
Merged

Fix build on DragonFlyBSD #5031

merged 1 commit into from
May 24, 2018

Conversation

daftaupe
Copy link
Contributor

License: MIT
Signed-off-by: Pierre-Alain TORET [email protected]

License: MIT
Signed-off-by: Pierre-Alain TORET <[email protected]>
@daftaupe daftaupe requested a review from Kubuxu as a code owner May 21, 2018 15:28
@djdv
Copy link
Contributor

djdv commented May 21, 2018

I'm curious if we can just omit these constraints altogether, so new platforms don't have to keep rediscovering this issue when trying to build on unsupported platforms.
To my knowledge, these files are only built when supplying the nofuse build tag anyway and the implementation for nofuse should work across all go implementations. (it seems to just return a string/error). Further limiting via GOOS seems unnecessary.

@Kubuxu Kubuxu added the RFM label May 22, 2018
@Kubuxu
Copy link
Member

Kubuxu commented May 22, 2018

@djdv please open issue about it, it will get lost here.

@whyrusleeping whyrusleeping merged commit d99d3d9 into ipfs:master May 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants