Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/refactor wait time #1

Merged
merged 7 commits into from
Nov 9, 2018
Merged

Feat/refactor wait time #1

merged 7 commits into from
Nov 9, 2018

Commits on Nov 6, 2018

  1. Allow randomized wait time w/o waiting 

    Refactor to seperate the act of waiting from reading the duration of the
next wait time, so that a calling module can use the waiting on its own

Also add a unit test
    @hannahhoward
    hannahhoward committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    e7c80bf View commit details
    Browse the repository at this point in the history

  2. Update travis version so tests run

    @hannahhoward
    hannahhoward committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    83086b5 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2018

  1. Move defer to correct position

    @hannahhoward
    hannahhoward committed Nov 9, 2018
    Configuration menu
    Copy the full SHA
    2cb8bd4 View commit details
    Browse the repository at this point in the history

  2. Refactor for DI approach + more testing

    @hannahhoward
    hannahhoward committed Nov 9, 2018
    Configuration menu
    Copy the full SHA
    f1bb990 View commit details
    Browse the repository at this point in the history

  3. Reorder params and defaults for delay

    @hannahhoward
    hannahhoward committed Nov 9, 2018
    Configuration menu
    Copy the full SHA
    f91cdb0 View commit details
    Browse the repository at this point in the history

  4. Remove sleeper only used for testing

    @hannahhoward
    hannahhoward committed Nov 9, 2018
    Configuration menu
    Copy the full SHA
    325e08e View commit details
    Browse the repository at this point in the history

  5. Minor cleanup

    @hannahhoward
    hannahhoward committed Nov 9, 2018
    Configuration menu
    Copy the full SHA
    d494d3f View commit details
    Browse the repository at this point in the history