Skip to content
This repository has been archived by the owner on Mar 9, 2022. It is now read-only.

Ipns.ReproviderDuration for PubSub GC #165

Closed
wants to merge 1 commit into from
Closed

Ipns.ReproviderDuration for PubSub GC #165

wants to merge 1 commit into from

Conversation

TobiaszCudnik
Copy link

go-ipfs-config part of libp2p/go-libp2p-pubsub-router#92, which fixes #8586.

@welcome
Copy link

welcome bot commented Jan 22, 2022

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@TobiaszCudnik TobiaszCudnik changed the title Added config.Ipns.ReproviderDuration for PubSub GC Ipns.ReproviderDuration for PubSub GC Jan 22, 2022
@TobiaszCudnik TobiaszCudnik marked this pull request as ready for review January 22, 2022 20:44
@BigLep BigLep requested a review from schomatis March 3, 2022 06:04
@BigLep
Copy link

BigLep commented Mar 3, 2022

@schomatis : as part of ipfs/kubo#8586 , can you please provide the reviews here?

@lidel
Copy link
Member

lidel commented Mar 9, 2022

go-ipfs-config got merged into go-ipfs repo: https://github.com/ipfs/go-ipfs/tree/master/config
If you feel this PR is still relevant, please reopen as a PR against go-ipfs

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

IPNS Pubsub Reprovider Duration (GC for unused topics)
3 participants