Skip to content
This repository has been archived by the owner on Mar 9, 2022. It is now read-only.

improve AutoRelay configuration, add config option for static relays #154

Merged
merged 3 commits into from
Nov 15, 2021

Conversation

marten-seemann
Copy link
Member

No description provided.

swarm.go Outdated
// RelayService.* controls the "auto relay service" feature.
// AutoRelay controls the "auto relay service" feature.
// When enabled, the node will use relays if it is not publicly reachable.
AutoRelay AutoRelay
Copy link
Member

@lidel lidel Nov 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am worried about ambiguity, better to be very clear around relay "service" and relay "client".
Would it be ok if we rename AutoRelay to more explicit RelayClient?

	RelayClient RelayClient

This way, we will have RelaySevice and RelayClient sections that are easier to wrap the head around without reading docs.

@marten-seemann Y/n? (I'm happy to apply changes)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with this. @vyzo, wdyt?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, fine by me.

Copy link
Member

@lidel lidel Nov 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done: 4cb1c6f

swarm.go Outdated Show resolved Hide resolved
lidel added a commit that referenced this pull request Nov 15, 2021
@aschmahmann
Copy link
Contributor

@marten-seemann is this ready to merge, or do you plan on adding any other config related to the go-libp2p upgrade?

@lidel is fine with how the config is setup and we'd like to do a release so we can unblock other things that rely on the various go-ipfs-config changes.

If you have more changes to make that's fine, we'll have to partially revert #146 (i.e. the libp2p things, but not the OptionalInteger changes), release and then re-release later.

@marten-seemann
Copy link
Member Author

@marten-seemann is this ready to merge, or do you plan on adding any other config related to the go-libp2p upgrade?

This is ready to merge. I'm planning to add another option for hole punching tomorrow, but that's a different thing, so it should be a separate PR.

If you have more changes to make that's fine, we'll have to partially revert #146 (i.e. the libp2p things, but not the OptionalInteger changes), release and then re-release later.

Not sure I understand. The changes in #146 are all correct, as far as I can tell, and needed by the go-libp2p update.

@aschmahmann aschmahmann merged commit 5f6630c into master Nov 15, 2021
@aschmahmann aschmahmann deleted the static-relays branch November 15, 2021 21:23
@aschmahmann aschmahmann mentioned this pull request Dec 1, 2021
80 tasks
laurentsenta pushed a commit to laurentsenta/kubo that referenced this pull request Feb 25, 2022
laurentsenta pushed a commit to laurentsenta/kubo that referenced this pull request Mar 4, 2022
laurentsenta pushed a commit to laurentsenta/kubo that referenced this pull request Mar 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants