fix sync error with go1.12 on darwin #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In go1.12, go switched how `file.Sync()` works on macos. Unfortunately, this also changed the "not supported" error to ENOTTY (called ENOTTY for legacy reasons) on macos. fixes ipfs/kubo#6028
ghost
assigned
Stebalien
commented
Feb 27, 2019
| @@ -8,7 +8,7 @@ import ( | |||
|
|
|||
| func isErrnoNotSupported(err error) bool { | |||
| switch err { | |||
| case syscall.EINVAL, syscall.ENOTSUP: | |||
| case syscall.EINVAL, syscall.ENOTSUP, syscall.ENOTTY: | |||
There was a problem hiding this comment.
It's called ENOTTY for historical reasons. It means "this ioctl is invalid for this file descriptor".
Kubuxu
approved these changes
Feb 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In go1.12, go switched how
file.Sync()works on macos. Unfortunately, this also changed the "not supported" error to ENOTTY (called ENOTTY for legacy reasons) on macos.fixes ipfs/kubo#6028