-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better logging for Graphsync traversal #167
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of nits but otherwise looks good.
Should we also add debug logs for when we're about to load a link so that we can see all the CIDs of successfully loaded links?
Also it seems like TestNetworkErrors/network_error_block_send is failing - I ran it again and the same test failed. |
Co-authored-by: dirkmc <[email protected]>
Have added the debug logs. That test is a flaky. See the same failure on master
|
* feat: fire network error when network disconnects during request (#164) * release: 0.6.1 * Better logging for Graphsync traversal (#167) * log gs traversal * Apply suggestions from code review Co-authored-by: dirkmc <[email protected]> * add debug logs * add debug logs Co-authored-by: dirkmc <[email protected]> * release: v0.6.2 (#168) * Fix/log blockstore reads (#169) * log gs traversal * Apply suggestions from code review Co-authored-by: dirkmc <[email protected]> * add debug logs * fixed logging * Apply suggestions from code review Co-authored-by: dirkmc <[email protected]> * fixed error Co-authored-by: dirkmc <[email protected]> * release: v0.6.3 (#170) * request queued hook * test request queued hook * release: v0.6.4 * Resolve 175 race condition, no change to hook timing (#178) * feat(requestmanager): add request timing (#181) * Add cancel request and wait function (#185) * fix(responsemanager): fix error codes (#182) enforce much tighter consistency with graphsync spec in usage of error codes * refactor: replace particular request not found errors with public error (#188) * release: 0.6.8 Co-authored-by: dirkmc <[email protected]> Co-authored-by: Aarsh Shah <[email protected]>
No description provided.