Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document internal methods on RequestManager and ResponseManager #221

Open
hannahhoward opened this issue Sep 24, 2021 · 0 comments
Open

Document internal methods on RequestManager and ResponseManager #221

hannahhoward opened this issue Sep 24, 2021 · 0 comments
Assignees
@rvagg
Labels
effort/hours Estimated to take one or several hours exp/intermediate Prior experience is likely helpful good first issue Good issue for new contributors P2 Medium: Good to have, but can wait until someone steps up

Comments

@hannahhoward
Copy link
Collaborator

Add comments explaining what they do, consider renaming them as need.

Add unit tests that actually check behavior where needed.
@hannahhoward hannahhoward added the need/triage Needs initial labeling and prioritization label Sep 24, 2021
@hannahhoward hannahhoward changed the title Document what internal methods on RequestManager and ResponseManager do, possibly add unit tests Document what internal methods on RequestManager and ResponseManager Sep 24, 2021
@hannahhoward hannahhoward changed the title Document what internal methods on RequestManager and ResponseManager Document internal methods on RequestManager and ResponseManager Sep 24, 2021
@hannahhoward hannahhoward mentioned this issue Sep 24, 2021
Merged
@hannahhoward hannahhoward added effort/hours Estimated to take one or several hours exp/intermediate Prior experience is likely helpful P2 Medium: Good to have, but can wait until someone steps up and removed need/triage Needs initial labeling and prioritization labels Sep 28, 2021
@hannahhoward hannahhoward added good first issue Good issue for new contributors and removed good first issue Good issue for new contributors labels Oct 23, 2021
marten-seemann pushed a commit that referenced this issue Mar 2, 2023
@aarshkshah1992
Fire a transfer queued event when a transfer is queued in Graphsync (#…
7794046 
…221)

* req queued event in GS

* fire a transfer queued event

* changes as per review and tests

* address nit

* update graphsync deps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rvagg rvagg

Labels
effort/hours Estimated to take one or several hours exp/intermediate Prior experience is likely helpful good first issue Good issue for new contributors P2 Medium: Good to have, but can wait until someone steps up
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rvagg @hannahhoward