Add transactional support to leveldb datastore. #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
raulk
commented
Sep 24, 2018
| @@ -130,7 +148,7 @@ func (d *datastore) QueryNew(q dsq.Query) (dsq.Results, error) { | |||
| }), nil | |||
| } | |||
|
|
|||
| func (d *datastore) QueryOrig(q dsq.Query) (dsq.Results, error) { | |||
| func (a *accessor) queryOrig(q dsq.Query) (dsq.Results, error) { | |||
There was a problem hiding this comment.
The exported QueryOrig and QueryNew are not used in IPFS to my knowledge. I made them private, as it feels wrong for these to be exported, but feel free to push back if I shouldn't have.
| @@ -49,21 +54,34 @@ func NewDatastore(path string, opts *Options) (*datastore, error) { | |||
| } | |||
|
|
|||
| return &datastore{ | |||
| DB: db, | |||
| path: path, | |||
| accessor: &accessor{ldb: db}, | |||
There was a problem hiding this comment.
This accessor is created with the LevelDB DB itself. The accessor on NewTransaction() is created with the transaction. I'm not married to the naming.
bigs
approved these changes
Sep 25, 2018
| func (d *datastore) Put(key ds.Key, value []byte) (err error) { | ||
| return d.DB.Put(key.Bytes(), value, nil) | ||
| // It allows to plug in either inside the `accessor`. | ||
| type levelDbOps interface { |
| } | ||
|
|
||
| func (d *datastore) QueryNew(q dsq.Query) (dsq.Results, error) { | ||
| func (a *accessor) queryNew(q dsq.Query) (dsq.Results, error) { |
There was a problem hiding this comment.
generally approve re-scoping this, but just make sure it's not breaking anything unexpectedly
| @@ -130,7 +148,7 @@ func (d *datastore) QueryNew(q dsq.Query) (dsq.Results, error) { | |||
| }), nil | |||
| } | |||
|
|
|||
| func (d *datastore) QueryOrig(q dsq.Query) (dsq.Results, error) { | |||
| func (a *accessor) queryOrig(q dsq.Query) (dsq.Results, error) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge ipfs/go-datastore#98 first.