added support for newly added Query.SeekPrefix #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
reviewed
Feb 6, 2019
| it.Seek([]byte(q.SeekPrefix)) | ||
| } else { | ||
| it.Seek(prefix) | ||
| } |
There was a problem hiding this comment.
This should probably seek to the "later" prefix (in case the seek prefix comes before the Prefix).
There was a problem hiding this comment.
Actually, this all depends on the ordering. If we've reversed the order, we'd want to seek to the "earlier" prefix.
Speaking of ordering, we technically need to apply the "seek" prefix after the order. Badger internally handles ordering by key (ascending or descending) but we have to apply all other orderings (e.g., by value) after the fact.
So, if we aren't applying any additional orders len(order) == 0, we're all good. Otherwise, we should either return a not supported error or apply a naive seek after ordering.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.